Add tests for notes overlay script#1403
Merged
myk002 merged 11 commits intoDFHack:masterfrom Mar 6, 2025
Merged
Conversation
wiktor-obrebski
force-pushed
the
tests/notes-overlay
branch
6 times, most recently
from
84f0abd to
c7d0937
Compare
wiktor-obrebski
force-pushed
the
tests/notes-overlay
branch
from
219e7ff to
5780653
Compare
We do not currently have an obvious way to center map on notes in tests and force-render map. Without it, we can test reliably only on current visible screen
Test failed if the cam has been in left-top corner of the map
wiktor-obrebski
force-pushed
the
tests/notes-overlay
branch
from
50d3018 to
da68893
Compare
myk002
approved these changes
Mar 2, 2025
myk002
reviewed
Mar 2, 2025
| config = { | ||
| target = 'notes', | ||
| mode = 'fortress' | ||
| } |
Member
There was a problem hiding this comment.
you can automatically run test setup and cleanup by defining config.wrapper. Example: test/assign-minecarts.lua or test/plugins/orders.lua
Contributor
Author
There was a problem hiding this comment.
I feel such helpers only make the code harder to understand, I prefer explicit definition for setup and cleanup per test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for
notesoverlay and forgui/notesscript.